Skip to content

test(core): modify request compression threshold values #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

test(core): modify request compression threshold values #7414

merged 1 commit into from
Oct 8, 2025

Conversation

smilkuri
Copy link
Contributor

@smilkuri smilkuri commented Oct 8, 2025 •
edited
Loading

Issue

Internal P312458591

Description

  • The test expected compression to occur at a precise byte count, but the actual payload size can vary depending on spec.
  • Changed from exact values (277,419/277,420 bytes) to a general range (100,000/300,000 bytes) to make the test compatible across different scenarios.

Testing

Locally

yarn test:integration

 RUN  v3.2.4 ../aws-sdk-js-v3/packages/core

 ✓ integ/defaults-mode.integ.spec.ts (4 tests) 9ms
 ✓ integ/configuration-file/aws-config-file.integ.spec.ts (2 tests) 18ms
 ✓ integ/request-handlers/request-handlers.integ.spec.ts (12 tests) 28ms
 ✓ integ/lazy-json-string.integ.spec.ts (1 test) 18ms
 ✓ integ/pagination.integ.spec.ts (1 test) 19ms
 ✓ integ/account-id-endpoint.integ.spec.ts (10 tests) 40ms
 ✓ integ/request-compression.integ.spec.ts (5 tests) 178ms
 ✓ integ/service-id.integ.spec.ts (9 tests) 4ms
 ✓ integ/waiters.integ.spec.ts (2 tests) 10038ms
   ✓ waiters > should poll until a return condition is met (http status)  5025ms
   ✓ waiters > should poll until a return condition is met (nested property)  5011ms

 Test Files  9 passed (9)
      Tests  46 passed (46)
   Start at  20:02:27
   Duration  11.71s (transform 2.56s, setup 0ms, collect 10.33s, tests 10.35s, environment 2ms, prepare 1.15s)

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@smilkuri smilkuri requested a review from a team as a code owner October 8, 2025 20:03
@smilkuri smilkuri merged commit 6b45d72 into main Oct 8, 2025
7 checks passed
@smilkuri smilkuri deleted the cloudwatch-integ-test branch October 8, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuhe kuhe kuhe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smilkuri @kuhe